On Thu, 9 Jul 2026 10:09:30 GMT, Viktor Klang <[email protected]> wrote:
>> This is some extremely basic overview about value class migrations. >> >> 1. Build: I intentionally skipped the streamlined build system installed by >> David Beaumont. Instead, I stressed the custom handling used by Value >> Objects JEP. (The "Preview Classes in Interim `javac`" section might go to >> general documentation later.) >> >> 2. Testing: I started from the motivations/goals and describe how those >> goals are accomplished. >> 3. Wrapper class caches: Some simple overview. >> >> There are definitely more topics to cover; feel free to raise. >> >> Paging @jddarcy and @viktorklang-ora for proofreading. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > doc/value-class-preview.md line 28: > >> 26: `value record`, respectively. >> 27: >> 28: The Value Objects JEP does not intend to introduce value classes that >> are not > > Too many negations in this sentence Done, converted this to a list of prerequisites. > doc/value-class-preview.md line 38: > >> 36: The preview classpath files are not available to the interim `javac`, >> most >> 37: commonly used in `SetupJavaCompilation` call. For each module that ships >> 38: preview-specific binaries, the following javac flag is required for a > > What's the definition of "preview-specific binaries" here? If we mean "value > object-capable binaries" I think we should be clear about that. Now defined at top about how "preview-specific" stuff overrides regular stuff. ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2633#discussion_r3555028955 PR Review Comment: https://git.openjdk.org/valhalla/pull/2633#discussion_r3555031368
