On Mon, 13 Jul 2026 20:39:10 GMT, Chris Plummer <[email protected]> wrote:

>> Ok. I'll work on this.
>
> After re-reviewing you comments, it seem the only thing you really want in 
> this section is to say "JDI supports value objects" and then mention the 
> constructor warning you've written above. The latter isn't really adding any 
> value since it is already explained in ObjectRefernece.thisObject(), so then 
> this section boils down to "JDI supports value objects".

No, I want ObjectReference to explain how an ObjectReference that mirrors a 
value object differs from one that mirrors an identity object. If that 
duplicates what is said in `StackFrame.thisObject()` then maybe `thisObject` is 
not where it should be being described. Or maybe it is worth noting in both 
places. But it certainly has to be noted in ObjectReference IMO.

-------------

PR Review Comment: 
https://git.openjdk.org/valhalla/pull/2639#discussion_r3575220141

Reply via email to