On Tue, 21 Jul 2026 13:41:58 GMT, Alan Bateman <[email protected]> wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one >> additional commit since the last revision: >> >> review: some minor refactoring of the intro on value objects > > src/hotspot/share/prims/jvmti.xml line 941: > >> 939: <p/> >> 940: In summary, tags for value objects use value equality semantics, and >> 941: the <eventlink id="ObjectFree"/> event is not sent for tagged value >> objects. > > I think it would be better to have just one paragraph for this topic in the > identityAndValueObjects section. How about just adding "The ObjectFree event > is not sent for tagged value objects" to the first paragraph, drop the "In > summary ..." line, and put the paragraph break before the sentence on > VMObjectAlloc/SampledObjectAlloc as they are different feature. > > It would also be useful if "Object tags" could link to the objectTags > section. Also the first use of jlong can go into a code tag so it's mono > space like the other usages. God suggestions, thanks. Fixed now. ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2659#discussion_r3624096780
