On Wed, Feb 25, 2015 at 10:53 AM, Poul-Henning Kamp <p...@phk.freebsd.dk> wrote: > Yeah, but now that we've rewritten the vtim.c code to not be locale > dependent, that's sort of pointless ?
Pointless but convenient because I would not have to keep it around in my working copy. > By all means use it to find such trouble! I just don't see the point > in adding it to the vmod on a permanent basis, unless we have code > we specifically need to test. Mainly for my very own convenience :) Also to sort of "document" locale awareness in relevant test cases, like regression tests would do with a bug that no longer exists. > (Remember: Not all machines may have any given locale installed...) That is indeed a problem. I suppose I could enforce a set of locales at build time with autoconf, but it may not be welcomed. I'll simply keep debug.setlocale around to find more issues. Cheers, Dridi _______________________________________________ varnish-dev mailing list varnish-dev@varnish-cache.org https://www.varnish-cache.org/lists/mailman/listinfo/varnish-dev
