Hi,
As discussed briefly during the last VDD in Hamburg, phk said that
everything should be in place to allow dynamic backend allocations
(ie. outside of pure VCL).
I looked quickly at the code right after the VDD with fgs, and at the
time there was a couple backend-related commits that had just showed
up. But I came to the conclusion that you could only add/remove a
backend and a tcp pool in vcl_init and vcl_fini.
Those operations can only be triggered by the CLI thread right now, so
it's not possible to programmatically add a backend at any arbitrary
time and still benefit from the existing facilities (stats, probes,
connection pools, etc).
I haven't made any progress since then, so I'm asking first what the
comment was about. I think I misunderstood what it was supposed to
mean at the time.
Also please find attached a tiny patch removing leftovers I found after the
VDD.
Regards,
Dridi
From 375d933ba3a90a87ed303aea80eae1a77be5f03c Mon Sep 17 00:00:00 2001
From: Dridi Boukelmoune <dridi.boukelmo...@gmail.com>
Date: Wed, 18 Mar 2015 11:50:31 +0100
Subject: [PATCH] Retire vdi_getfd_f leftovers
---
bin/varnishd/cache/cache_backend.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/bin/varnishd/cache/cache_backend.c b/bin/varnishd/cache/cache_backend.c
index a02a7d8..c554397 100644
--- a/bin/varnishd/cache/cache_backend.c
+++ b/bin/varnishd/cache/cache_backend.c
@@ -77,7 +77,7 @@ VBE_Healthy(const struct backend *backend, double *changed)
* Get a connection to the backend
*/
-static int __match_proto__(vdi_getfd_f)
+static int
vbe_dir_getfd(const struct director *d, struct busyobj *bo)
{
struct vbc *vc;
--
2.1.0
_______________________________________________
varnish-dev mailing list
varnish-dev@varnish-cache.org
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-dev
