Since I smelled a consensus, here are the patches to remove the
"--enable-tests"
--
Guillaume Quintard
On Wed, Mar 2, 2016 at 9:51 AM, Guillaume Quintard <
guilla...@varnish-software.com> wrote:
> Can we get rid of the "if ENABLE_TESTS"? Tests should be executed. If you
> don't want to run them, don't run "make check".
>
> --
> Guillaume Quintard
>
From f2dc64537ab52fb8a9913c7b1300830d1b5a8e1e Mon Sep 17 00:00:00 2001
From: Guillaume Quintard <guilla...@varnish-software.com>
Date: Wed, 2 Mar 2016 16:58:45 +0100
Subject: [PATCH 2/2] Get rid of --enable-tests
---
configure.ac | 5 -----
1 file changed, 5 deletions(-)
diff --git a/configure.ac b/configure.ac
index 9526ce1..b24e41f 100644
--- a/configure.ac
+++ b/configure.ac
@@ -636,11 +636,6 @@ AC_ARG_ENABLE(debugging-symbols,
AC_SUBST(AM_LT_LDFLAGS)
-# --enable-tests
-AC_ARG_ENABLE(tests,
- AS_HELP_STRING([--enable-tests],[build test programs (default is NO)]))
-AM_CONDITIONAL([ENABLE_TESTS], [test x$enable_tests = xyes])
-
# Command line for compiling VCL code. I wish there were a simple way
# to figure this out dynamically without introducing a run-time
# dependency on libtool.
--
2.7.1
From 8133f2b3382151178baa3ad75386de6c29f9bbc9 Mon Sep 17 00:00:00 2001
From: Guillaume Quintard <guilla...@varnish-software.com>
Date: Wed, 2 Mar 2016 16:58:22 +0100
Subject: [PATCH 1/2] Always enable libvarnish test
---
lib/libvarnish/Makefile.am | 2 --
1 file changed, 2 deletions(-)
diff --git a/lib/libvarnish/Makefile.am b/lib/libvarnish/Makefile.am
index 967ec9c..bdda37d 100644
--- a/lib/libvarnish/Makefile.am
+++ b/lib/libvarnish/Makefile.am
@@ -42,7 +42,6 @@ libvarnish_la_CFLAGS = \
libvarnish_la_LIBADD = ${RT_LIBS} ${NET_LIBS} ${LIBM} @PCRE_LIBS@ \
@SAN_LDFLAGS@
-if ENABLE_TESTS
TESTS = vnum_c_test
noinst_PROGRAMS = ${TESTS}
@@ -53,4 +52,3 @@ vnum_c_test_LDADD = ${LIBM}
test: ${TESTS}
@for test in ${TESTS} ; do ./$${test} ; done
-endif
--
2.7.1
_______________________________________________
varnish-dev mailing list
varnish-dev@varnish-cache.org
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-dev
