nolan de souza wrote: > > > On Wed, Oct 8, 2008 at 12:09 AM, Jason Spiro <[EMAIL PROTECTED] > <mailto:[EMAIL PROTECTED]>> wrote: > > 2008/10/7 nolan de souza <[EMAIL PROTECTED] > <mailto:[EMAIL PROTECTED]>> wrote: > > I have a few patches for building VirtualBox trunk on Windows > with just > > Visual Studio 2005 (and the PSDK that comes with it) and without > having to > > install the external PSDK as mentioned in > > "http://www.virtualbox.org/wiki/Windows%20build%20instructions"; > > > > Would it be nice to have these patches published... I can do > that? Or do we > > really don't care about that kinda setup? > > Just curious: Do they break anything for users of other Microsoft > compilers? > > > Don't think so. Nonetheless, I'll review my changes to make sure that > nothing breaks in the builds. > > Well, without the "externally" installed PSDK, the build fails at couple > of places. Even though the build instructions above say that the PSDK > coming with VS2005 should work, the build scripts are not equipped to > deal with this setup. PSDK is not found and further up, the Midl.exe & > MC.exe within "Microsoft Visual Studio8\Common7" folder are not found.
The easiest way of getting such changes included is to contribute them. Having separate patches floating around and getting stale over time isn't a good solution. The easiest way is sending them to this list and state that you release them under the MIT license (other options and details on http://virtualbox.org/wiki/Contributor_information ). We gladly accept anything which is doing more good than harm. Of course we prefer perfectly clean changes, however we're willing to to a reasonable bit of tidying ourselves. Lowering the build hurdles on Windows is definitely a good thing. Klaus _______________________________________________ vbox-dev mailing list [email protected] http://vbox.innotek.de/mailman/listinfo/vbox-dev
