Hi, I started looking at the patch.
The change you made to the sed line will break the case where the pkg FMRI is: "pkg://solaris/system/[email protected]:20121012T032837Z" We want the 2nd occurrence of "5.12", but your new sed will retreive the first one because it is designed to also handle OI Hipster'15: "pkg://openindiana.org/system/[email protected]:20150621T130732Z" i.e. the case where "-" follows "0.5.11". Also, the only different parse format here is for OI Hipster'15. The other 2 cases (OI 151a8 and OmniOS Bloody) should be identical to parsing the "pkg://solaris/system/[email protected],5.11-0.175.0.0.0.1.0:20111012T032837Z" case. I'll try fix this to handle both as well as the other formats. Regards, Ram. On 06/24/15 06:02 PM, Ramshankar wrote: > On 06/24/15 04:52 PM, Jim Klimov wrote: >> Hello Ramshankar, >> >>> I'll take a look at the patch, but releasing it as you did originally >>> under the MIT license >> > rather than GPLv2 is what would be suitable for us to merge right away. >>> Let me know if this is possible. >> Yes, sure. There was a bit of logical conflict between >> >> 1) VirtualBox site suggestions of releasing patches under MIT license, and >> >> 2) Changing an original file (under GPLv2) should generally not change >> the existing license. >> >> Anyhow, the March brew of the patch was explicitly under MIT, and today's >> fix for OI Hipster changes is also trivial (beside examples in comments, it >> amounts to under a dozen symbols in the sed expression). >> >> I don't have a strong opinion about picking either of the licenses, but I >> do have a strong desire to upstream these fixes rather than maintain them >> separately and apply on every upgrade ;) So if this requires reinstating the >> MIT license for the patch file - perfectly fine with me, consider it being >> so. Should I change the GitHub wording as well? >> >> FYI, make sure to take a look at the most recent state on GitHub - I >> fixed the patch to apply to 5.0rc1 as well as 4.3.28, a few minutes ago. > Thanks. Yes clearly stating that it is licensed as MIT causes us the > least amount of complications for us. > > I will be looking at what's published here: > https://github.com/jimklimov/vboxconfig_sh/blob/master/vboxconfig.sh.patch > > Regards, > Ram. > > > >> Thanks, >> Jim Klimov >> >> >> >> ----- Исходное сообщение ----- >> От: Ramshankar <[email protected]> >> Дата: Wednesday, June 24, 2015 16:15 >> Тема: Re: [vbox-dev] Patch to support installation on non-Sun/Oracle Solaris >> hosts >> Кому (To): [email protected] >> Копия (Cc): [email protected] >> >> >> >> >> >> >> ----------------------------------------------------------- >> >> >> > _______________________________________________ >> > vbox-dev mailing list >> > [email protected] >> > https://www.virtualbox.org/mailman/listinfo/vbox-dev >> >> -- >> >> +============================================================+ >> | | >> | Климов Евгений, Jim Klimov | >> | технический директор CTO | >> | ЗАО "ЦОС и ВТ" JSC COS&HT | >> | | >> | +7-903-7705859 (cellular) mailto:[email protected] | >> | CC:[email protected],[email protected] | >> +============================================================+ >> | () ascii ribbon campaign - against html mail | >> | /\ - against microsoft attachments | >> +============================================================+ >> >> >> >> | >> >>> Hi, >>> >>> I'll take a look at the patch, but releasing it as you did originally >>> under the MIT license rather than GPLv2 is what would be suitable for us to >>> merge right away. >>> >>> Let me know if this is possible. >>> >>> Regards, >>> Ram. >>> >>> >>> On 06/24/15 12:44 PM, Jim Klimov wrote: >>> Hello all, > > Earlier in March I posted a patch that fixes >>> installation of VirtualBox on non-Oracle Solaris hosts (e.g. OpenIndiana >>> and OmniOS). Lest it be lost in the list archives, I moved the patch (now >>> licensed as GPLv2 to match VirtualBox licensing) and an accompanying README >>> to GitHub: https://github.com/jimklimov/vboxconfig_sh > > Feel free to >>> add the changes into the upstream distribution, so such hackery won't be >>> needed ;) > > Thanks, > Jim Klimov > > >>> _______________________________________________ > vbox-dev mailing list > >>> [email protected] https://www.virtualbox.org/mailman/listinfo/vbox-dev >> | >> >> >> ----------------------------------------------------------- >> > > _______________________________________________ > vbox-dev mailing list > [email protected] > https://www.virtualbox.org/mailman/listinfo/vbox-dev _______________________________________________ vbox-dev mailing list [email protected] https://www.virtualbox.org/mailman/listinfo/vbox-dev
