On 1/10/2018 12:13 AM, Kalogrianitis Socratis wrote:
The problem is that the USB controller type does not map to USB specification
revisions at all.
Just trying to get it as close to the GUI as (un-confusingly) possible. Your
average Joe is going to know bupkis about OHCI or EHCI, or 1.1 or 2.0. You
could even take the *HCI out of the settings, and nobody would complain ;)
Fortunately, the average Joe also does not know that VBoxManage
exists, so that's not a concern.
For showvminfo, just replacing 'USB' with 'OHCI' is probably the simplest
change that's not misleading and does not need to go into excessive detail to
be accurate.
Perfect! I believe that you're familiar as well with the "K.I.S.S." principle ;)
In the end I went with 'OHCI USB', 'EHCI USB', 'xHCI USB' in the
showvminfo output.
For that reason, changing the machine readable output is a big no-no and
pointless -- it will break existing software that parses the output, and does
not help users who are not expected to look at it. Changing the human-readable
output is OTOH perfectly fine.
I thought that you might object to that. I simply wasn't aware of parsers.
Which makes sense to keep it as is. If you want to machine parse the settings,
you'd better know what's going on...
I'll also look at changing the modifyvm --usb option, or rather leaving it in
place but hidden and adding modifyvm --ohci.
Hey, that's a good one too! Or, something like:
VBoxManage modifyvm --<usbohci|usbehci|usbxhci> <on|off>
while keeping the "--usb on|off" available for backwards compatibility?
That is basically what I've done now. The modifyvm subcommand takes
'--usbohci'; '--usb' still exists for compatibility but is hidden.
Regards,
Michal
_______________________________________________
vbox-dev mailing list
[email protected]
https://www.virtualbox.org/mailman/listinfo/vbox-dev
