Re: [vchkpw] Working towards vpopmail 5.4 stable

[Dave Richardson - Lists]

I confess I'm in the same boat as Jeff.  I actually had some trouble 
with 5.3-something version when I did my install, so I went with 5.2.1.

I haven't made any customizations to any code other than what is 
described here:
http://www.pipeline.com.au/staff/mbowe/isp/webmail-server.htm

Thanks,
D.
Jeff Garvas wrote:

Pardon my ignorance, but will a 5.4 stable version require any major
modifications to a working 5.2.1 installation?
Has anything changed in terms of the sql table layout or anything else that
would make upgrading more significant than simply running configure, make,
make install?
I put off installing for awhile because I feared this would happen, now I
get to upgrade a 5.2.1 install soon.   Can't wait to see the new features :)
-Jeff

 

-----Original Message-----
From: Ken Jones [mailto:[EMAIL PROTECTED]
Sent: Wednesday, June 04, 2003 11:54 AM
To: Moshe Jacobson; [EMAIL PROTECTED]
Subject: Re: [vchkpw] Working towards vpopmail 5.4 stable
Seems like a reasonable change.
I put it in. Needs testing!
Looks like we will start a series of devel releases to test
these changes. I'll package one up end of day tomorrow.
Ken Jones

On Wednesday 04 June 2003 9:37 am, Moshe Jacobson wrote:
   

On Tue, 3 Jun 2003, Ken Jones wrote:
     

Does anyone have any code changes they would like to get into the
next release? I want to put together a new stable version 5.4.
Hopefully release it in the next few weeks.
       

There seems to be a problem in th maildir_to_email() function in
vdelivermail.c.  If the domain dir is not directly under the
DOMAINS_DIR, e.g. /home/vpopmail/domains/1/example.com, then a user
[EMAIL PROTECTED] will have a maildir of:
   /home/vpopmail/domains/1/example.com/joe/Maildir/

and maildir_to_email() returns an email address of [EMAIL PROTECTED] instead of
[EMAIL PROTECTED]
This should definitely be fixed as it is a simple and obvious bug.

My (untested) fix is as follows.  Change the following block located
near the bottom of maildir_to_email():
----
for( pnt = last + (strlen(DOMAINS_DIR)+2); (*pnt && *pnt != '/' && j <
255); ++pnt, ++j ) { email[j] = *pnt;
}
----
to:

----
pnt = last + strlen(DOMAINS_DIR) + 2;
while( *(pnt+1) == '/' ) pnt+=2;
for( ; (*pnt && *pnt != '/' && j < 255); ++pnt, ++j ) {
 email[j] = *pnt;
}
----
Moshe