Bugs item #2726725, was opened at 2009-04-02 14:42
Message generated for change (Comment added) made by danielel
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=611248&aid=2726725&group_id=95403
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Closed
>Resolution: Fixed
Priority: 5
Private: No
Submitted By: Ferenc Wágner (wferi)
Assigned to: Daniele Lacamera (danielel)
Summary: wrong unicast test
Initial Comment:
unicast_ip() in vde_l3.c starts by:
if(ip&0xE0000000)
return 0;
but based on
http://www.geocities.com/SiliconValley/Vista/8672/network/ipaddr.html#A23 it
should be
if (ip & 0xE0000000 == 0xE0000000)
return 0;
instead, in my opinion. And the error message should state why the program
"Cannot set ip address to X.X.X.X" (because it isn't a unicast address).
Even better, get rid of this test altogether, what is it good for?
Thanks,
Feri.
----------------------------------------------------------------------
>Comment By: Daniele Lacamera (danielel)
Date: 2010-05-08 19:29
Message:
Fixed in svn r410
----------------------------------------------------------------------
Comment By: Ferenc Wágner (wferi)
Date: 2009-04-02 14:50
Message:
Btw. netmask validation is broken as well, /255.255.255.0 works, /24 does
not (in version 2.2.2).
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=611248&aid=2726725&group_id=95403
------------------------------------------------------------------------------
_______________________________________________
vde-users mailing list
vde-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/vde-users
