----- Original Message ----- > From: "Shu Ming" <shum...@linux.vnet.ibm.com> > To: "VDSM Project Development" <vdsm-devel@lists.fedorahosted.org> > Sent: Tuesday, March 19, 2013 4:03:00 AM > Subject: [vdsm] Does we really need _addTask() in taskManager.py? > > Hi, > > I am reading the code in taskManager.py. It seems that _addTask was > defined in class Taskmanager, but no else to use them. Also, class > Taskmanager get a similar function queue() which is used. Does we > really > need _addTask() function or just remove it? > You are right, there is no link to _addTask method, and the only different between it to the queue method is the Task.validateID call. Please check if the validation is necessary, if it is just add it to 'queue' before adding the task to the dict and you can remove _addTask
> -- > --- > 舒明 Shu Ming > Open Virtualization Engineerning; CSTL, IBM Corp. > Tel: 86-10-82451626 Tieline: 9051626 E-mail: shum...@cn.ibm.com or > shum...@linux.vnet.ibm.com > Address: 3/F Ring Building, ZhongGuanCun Software Park, Haidian > District, Beijing 100193, PRC > > > _______________________________________________ > vdsm-devel mailing list > vdsm-devel@lists.fedorahosted.org > https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel > _______________________________________________ vdsm-devel mailing list vdsm-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel
