Federico Simoncelli has posted comments on this change.
Change subject: BZ#741658 Move VM to Down if libvirt reports VIR_ERR_NO_DOMAIN
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File vdsm/utils.py
Line 390: statsFunction()
Line 391: except Exception, e:
Line 392: if not self.handleStatsException(e):
Line 393: self._log.error("Stats function failed:
%s",
Line 394: statsFunction,
exc_info=True)
The idea is to log the error only if it wasn't taken care by the handler (which
in our specific case is logging anyway).
Line 395:
Line 396: self._stopEvent.wait(waitInterval)
Line 397: intervalAccum = (intervalAccum + waitInterval) %
maxInterval
Line 398:
--
To view, visit http://gerrit.usersys.redhat.com/984
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id6262fb2504534c56fdec246937423d629f92e13
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
