Dan Kenigsberg has posted comments on this change.

Change subject: BZ#741856 delete rhevm cert before conf_update
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(2 inline comments)

....................................................
File vdsm_reg/deployUtil.py.in
Line 1327:     return data
Line 1328: 
Line 1329: def nodeCleanup():
Line 1330:     if isOvirt():
Line 1331:         CACERT, dontcare = certPaths('')
having _ instead of "dontcare" is cooler ;-)
Line 1332:         if os.path.exists(CACERT):
Line 1333:             ovirtfunctions.ovirt_safe_delete_config(CACERT)
Line 1334: 
Line 1335: def getRhevmCert(IP, port):


....................................................
File vdsm_reg/vdsm-config
Line 82:                        sed --copy -i 
"s/\(^vdc_host_name=\)\(..*$\)/\1${vdc_managment_server}/" \
Line 83:                                /etc/vdsm-reg/vdsm-reg.conf
Line 84: 
Line 85:                        res=`python "$DEPLOY_UTIL" --node-cleanup`
Line 86:             ret_val=$?
sorry, tab alert
Line 87:             echo "$res" >> $LOG 2>&1
Line 88:             if [ ! $ret_val -eq 0 ];then
Line 89:                 echo "Node cleanup failed" >> $LOG 2>&1
Line 90:             fi


--
To view, visit http://gerrit.usersys.redhat.com/987
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8bc1dc1fb7fa2ffc0bcb1f6389b34a9ee82b4197
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yotam Oron <[email protected]>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to