Saggi Mizrahi has posted comments on this change. Change subject: [WIP] Logging in OOP ......................................................................
Patch Set 2: I would prefer that you didn't submit this (1 inline comment) .................................................... File vdsm/storage/processPool.py Line 39: class Timeout(RuntimeError): pass Line 40: class NoFreeHelpersError(RuntimeError): pass Line 41: class PoolClosedError(RuntimeError): pass Line 42: Line 43: class QueueHandler(logging.Handler): Move to logUtils. We might use it in supervdsm as well Line 44: """ Line 45: This handler sends events to a queue. Typically, it would be used together Line 46: with a multiprocessing Queue to centralise logging to file in one process Line 47: (in a multi-process application), so as to avoid file write contention -- To view, visit http://gerrit.usersys.redhat.com/985 To unsubscribe, visit http://gerrit.usersys.redhat.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iabe8abf31f46469e3c6fdac670f0ff03fe9cefe8 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
