Dan Kenigsberg has posted comments on this change.
Change subject: Made spm securing logic more generic
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(3 inline comments)
....................................................
File vdsm/storage/securable.py
Line -3
Line -2
Line -1
Line 0
Line 1: from threading import Event
Let's live up to the Berrange bar and add a GPL notice here.
Line 2: from functools import wraps
Line 3:
Line 4: class SecureError(RuntimeError): pass
Line 5:
Line -1
Line 0
Line 1: from threading import Event
Line 2: from functools import wraps
Line 3:
and a docstring would be great.
Line 4: class SecureError(RuntimeError): pass
Line 5:
Line 6: class Securable(type):
Line 7: def __new__(mcs, name, bases, fdict):
....................................................
File vdsm/storage/spm.py
Line 293: self.log.debug("Registering with state change event")
Line 294:
sp.StatsThread.onDomainConnectivityStateChange.register(self._upgradePoolDomain)
Line 295: self.log.debug("Running initial domain upgrade threads")
Line 296: for sdUUID in self._domainsToUpgrade:
Line 297: threading.Thread(target=self._upgradePoolDomain,
args=(sdUUID, True), kwargs={"__securityOverride": True}).start()
unrelated, but still: WARNING, nondeamonic long thread.
Line 298:
Line 299: @secured
Line 300: def _upgradePoolDomain(self, sdUUID, isValid):
Line 301: # This method is called everytime the
onDomainConnectivityStateChange
--
To view, visit http://gerrit.usersys.redhat.com/991
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2e16feafc03d6efe5c904b18d4d27177dd14b905
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
