Federico Simoncelli has posted comments on this change.
Change subject: [WIP] Update the rpm pre scriptlet
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File vdsm.spec.in
Line 63: %clean
Line 64: %{__rm} -rf %{buildroot}
Line 65:
Line 66: %pre
Line 67: getent passwd vdsm >/dev/null || \
I agree on the use of getent only because this way we don't need to hide the
output for useradd (which could fail for other reasons... not that anyone will
ever notice it at the right time).
Line 68: useradd -r -u 36 -g kvm -d /var/lib/vdsm \
Line 69: -s /sbin/nologin -c "Node Virtualization Manager" vdsm
Line 70: usermod -a -G qemu vdsm
Line 71:
--
To view, visit http://gerrit.usersys.redhat.com/911
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8effe06b95b008eafff63a75a16f0518788bd9af
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
