Dan Kenigsberg has posted comments on this change. Change subject: The start of exceptions being independent from the interface ......................................................................
Patch Set 4: I would prefer that you didn't submit this (1 inline comment) .................................................... File vdsm/storage/dispatcher.py Line 95: self.log.error(e, exc_info=True) Line 96: defaultException = ctask.defaultException Line 97: if defaultException and hasattr(defaultException, "response"): Line 98: resp = defaultException.response() Line 99: defaultException = (resp['status']['code'], resp['status']['message']) very confusing. is defaultException an exception or a tuple? Line 100: return se.generateResponse(e, defaultException) Line 101: Line 102: return se.generateResponse(e) Line 103: except: -- To view, visit http://gerrit.usersys.redhat.com/1021 To unsubscribe, visit http://gerrit.usersys.redhat.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic85a93ff0aa42369db477bfef2d7a340851cae73 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
