Eduardo Warszawski has posted comments on this change. Change subject: BZ#751629 - Avoid migrate master if MSD is obsolete. ......................................................................
Patch Set 1: (1 inline comment) .................................................... File vdsm/storage/sp.py Line 1110: if new_msdUUID != BLANK_POOL_UUID: Line 1111: #Trying to migrate master failed to reach actual msd. Line 1112: raise se.StorageDomainAccessError(sdUUID) Line 1113: else: Line 1114: if self.masterDomain.sdUUID == sdUUID: MSD is lost. RHEV-M does reconstruct master and after that tries to deactivate the outdated (former) MSD. If the outdated MSD is still unreachable AttributeError is raised. If meanwhile the outdated MSD was reconnected, isMaster() will be true and masterMigrate() will be triggered with BLANK_UUID as the new master, going to _unmountLastMaster() and below. Line 1115: #Maybe there should be information in the exception that the UUID is Line 1116: #not invalid because of its format but because it is equal to the SD. Will be less confusing. Line 1117: #TODO: verify in masterMigrate(). Line 1118: if sdUUID == new_msdUUID: -- To view, visit http://gerrit.usersys/1091 To unsubscribe, visit http://gerrit.usersys/settings Gerrit-MessageType: comment Gerrit-Change-Id: I995b86f62ee9026875b966d66f216d295aac9eba Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo Warszawski <[email protected]> Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Eduardo Warszawski <[email protected]> Gerrit-Reviewer: Haim Ateya <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
