Igor Lvovsky has posted comments on this change.
Change subject: BZ#750528 - pool refresh should not change metadatata.
......................................................................
Patch Set 5: I would prefer that you didn't submit this
(3 inline comments)
....................................................
File vdsm/storage/sp.py
Line 1067: If domain is marked as master but we have a different one.
Line 1068: """
Line 1069: if domain.sdUUID == self.masterDomain.sdUUID:
Line 1070: self.log.error("%s is master of (this) pool %s can't set
regular", domain.sdUUID, self.spUUID)
Line 1071: return
This check is redundant, you already check it in caller
Line 1072: #get the POOL MD of the outdated master SD
Line 1073: domPoolMD = self._getPoolMD(domain)
Line 1074: if PMDK_MASTER_VER not in domPoolMD.iterkeys():
Line 1075: self.log.error("Domain %s is marked master but lacks %s",
Line 1072: #get the POOL MD of the outdated master SD
Line 1073: domPoolMD = self._getPoolMD(domain)
Line 1074: if PMDK_MASTER_VER not in domPoolMD.iterkeys():
Line 1075: self.log.error("Domain %s is marked master but lacks %s",
Line 1076: domain.sdUUID, PMDK_MASTER_VER)
I am confused, why do you think that domain is a master?
you check it for every domain, do you?
Line 1077: elif domPoolMD[PMDK_MASTER_VER] >= self.getMasterVersion():
Line 1078: self.log.error("VDSM PANIC! Domain %s has pool ver %s \
Line 1079: ge than this pool %s version", domain.sdUUID,
self.getMasterVersion())
Line 1080: #Deprecated master: change role to regular
Line 1075: self.log.error("Domain %s is marked master but lacks %s",
Line 1076: domain.sdUUID, PMDK_MASTER_VER)
Line 1077: elif domPoolMD[PMDK_MASTER_VER] >= self.getMasterVersion():
Line 1078: self.log.error("VDSM PANIC! Domain %s has pool ver %s \
Line 1079: ge than this pool %s version", domain.sdUUID,
self.getMasterVersion())
Something wrong here.
why error? amount of parameters is wrong and message itself not clear
Line 1080: #Deprecated master: change role to regular
Line 1081: else:
Line 1082: with domPoolMD.transaction():
Line 1083: domain.changeRole(sd.REGULAR_DOMAIN)
--
To view, visit http://gerrit.usersys.redhat.com/1082
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I12e3e700ff67a527c367533bf9f5654e8760a118
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo Warszawski <ewars...@redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Eduardo Warszawski <ewars...@redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvov...@redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com>
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/vdsm-patches
