Dan Kenigsberg has posted comments on this change.
Change subject: Add support for new 'domxml' parameter to create VM API.
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(4 inline comments)
only partial review, too tired.
....................................................
File vdsm/clientIF.py
Line 694: # FIXME! blobXml should be passed via vmParams
directly from RHEV-M
why should it be passed if it has never existed?
why bother with exception instead of a simple if?
....................................................
File vdsm/libvirtvm.py
Line 726: # Sometimes devices haven't defined address
does not have
Line 727: self.log.warning("Can't parse device '%s'(type = %s)
address: (%s)", device, devType, str(e))
exc_info=True
Line 770: address = self._getDeviceAddress(device='interface',
devType='bridge')
there may be multiple bridges per VM. you must look them up by the "alias"
element.
--
To view, visit http://gerrit.ovirt.org/236
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1ba723122273ace3faeced1ea9580b510f84d92c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
