Dan Kenigsberg has posted comments on this change.
Change subject: Pass the direct disk in cmdLine.
......................................................................
Patch Set 3: I would prefer that you didn't submit this
(1 inline comment)
please also verify that this works on recovery and migration.
....................................................
File vdsm/libvirtvm.py
Line 1004: drv.iface = drive['if']
gosh, it is ugly. not your fault, of course.
how about passing **{'if': drive['if']} ?
--
To view, visit http://gerrit.ovirt.org/259
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I971e2c0d60043f0ee0c25a30156edd770ec22dfb
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
