Dan Kenigsberg has posted comments on this change. Change subject: Add PolicyKit support to access libvirt ......................................................................
Patch Set 2: I would prefer that you didn't submit this (1 inline comment) Earlier I've missed the fact that polkit is going to be used only in Fedora, not downstream. Over RHEL Vdsm is to continue editing /etc/libvirt/libvirt.conf. I can live with that. However I still have a minor question. .................................................... File vdsm/libvirtconnection.py Line 113: except libvirt.libvirtError: Is this really needed? I think libvirt already has a fallback from openAuth to open: I know that openAuth works fine even if libvirtd has "none" for authentication. Wouldn't it work well with "polkit"? -- To view, visit http://gerrit.ovirt.org/322 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia781accc36d9d9a8e6b49099dc5126aa557831a3 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
