Federico Simoncelli has posted comments on this change. Change subject: The configuration values must be strings ......................................................................
Patch Set 2: > BTW, config.parameters should be called _parameters. > I even dare to suggest that they should be deleted after use. We didn't discuss this but I thought it was nice to expose them instead. Any tool would have the opportunity to read the comments and the default values (for example we could have something like: "vdsm-tool help vars vm_sample_disk_latency_interval" to display the comment/default). I remember I spent some time researching if it was possible doing it in ConfigParser object but it wasn't (I should have subclassed it). -- To view, visit http://gerrit.ovirt.org/459 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id51af12b809906848f9dfbde17c42ce56b887772 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
