Dan Kenigsberg has posted comments on this change. Change subject: Split removeNameFormat functionality. ......................................................................
Patch Set 1: I would prefer that you didn't submit this (1 inline comment) .................................................... File vdsm/storage/image.py Line 248: def removeNameFormat(self, uuid): function name is not clear it all, and its docstring makes it worse. function is not expected to be public, so the name should show it (_). how about _deletedVolumeName()? -- To view, visit http://gerrit.ovirt.org/441 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icbf24988a4367fa806f4c4c41519314daf0f6dab Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
