Dan Kenigsberg has posted comments on this change.

Change subject: Produce once the SD in FileVolume.getAllChildrenList()
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(2 inline comments)

just a couple of annoying questions.

....................................................
File vdsm/storage/fileVolume.py
Line 401
what's the great benefit? Doesn't the cache avoid the read production heavy 
load?

....................................................
File vdsm/storage/volume.py
Line 680
I know you hate those "interface" functions, but why did you kill this one here 
and now?

--
To view, visit http://gerrit.ovirt.org/442
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I732b5c67d605bbf394e05b67a3c8b80336dd3871
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to