Dan Kenigsberg has posted comments on this change.
Change subject: InvalidParameterException() takes two args
......................................................................
Patch Set 3: I would prefer that you didn't submit this
(1 inline comment)
btw, same bug exists at hsm.public_moveImage.
Igor, I do not notice this elsewhere.
....................................................
File vdsm/storage/storage_connection.py
Line 84: raise se.InvalidParameterException(paramName,
'parameter "%s" is missing from connection info %s' % (paramName, con.get('id',
"")))
It could have been even better if you had dropped the param name form the
string. why repeat it in the final log line?
--
To view, visit http://gerrit.ovirt.org/432
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id725f20ecf2836ab73bb8ae28ed0550574365fe7
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
