Federico Simoncelli has posted comments on this change. Change subject: Hotplug/Hotunplug disks ......................................................................
Patch Set 3: (1 inline comment) .................................................... File vdsm/utils.py Line 802: def validateMinimalKeySet(dictionary, keys): Nice, I'm sure that also the current code can benefit from this. Can you introduce this using a different patch and using it where needed? Then you can place your hotplug patch on top of that. Raising an exception would be more pythonic, eg: raise ValueError, param -- To view, visit http://gerrit.ovirt.org/409 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5feefdba390c4b885aaa5e61f40410419acb3b3c Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
