Dan Kenigsberg has posted comments on this change. Change subject: caps.py/clientIF/libvirtvm: include oVirt Node ......................................................................
Patch Set 4: I would prefer that you didn't submit this (2 inline comments) minor comments only .................................................... Commit Message Line 9: Adding oVirt Node validation commit message is not very clear: you are adding oVirt Node as a supported host OSName. I do not know what do you mean by "Adding oVirt Node validation" .................................................... File vdsm/clientIF.py Line 1013: or prod == caps.OSName.RHEVH: this could be a bit shorter with prod in (caps.OSName.RHEL, caps.OSName.OVIRT, caps.OSName.RHEVH) but that may be more of a personal taste. -- To view, visit http://gerrit.ovirt.org/454 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8e59867abaf4cd6e9f142356b05fca15992ae300 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
