Dan Kenigsberg has posted comments on this change. Change subject: Integrate new mounting code to blockSD ......................................................................
Patch Set 1: I would prefer that you didn't submit this (2 inline comments) .................................................... File vdsm/storage/blockSD.py Line 845: masterMount.mount(vfstype="ext3") why not use fileUtils.FSTYPE_EXT3 ? Line 863: masterMount = self._getMasterMount() huh? assignment with no usage? -- To view, visit http://gerrit.ovirt.org/546 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I14bf200a53331e23b65d77732c8ecd663f5772ec Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
