Dan Kenigsberg has posted comments on this change.

Change subject: vdsmd.8: update man page to reference oVirt
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(5 inline comments)

good idea - but more work should be done.

....................................................
File vdsm/vdsmd.8
Line 16: vdsmd \- oVirt Engine Host Agent
keep "host agent" uninitialized

Line 25: and Fedora Linux hosts. VDSM manages and monitors the host's
no need to mention Fedora here - we plan to support other distributions.

say below that only RHEL and Fedora are currently supported.

Line 142: .FN /var/lib/vdsm/data-center/
has this been decided? (haven't read my mail)

Line 158: .SH COPYRIGHT
please find a place to refer to upstream wiki page

Line 159: Copyright 2010 Red Hat, Inc. License GPLv2: GNU GPL Version 2 
<http://gnu.org/licenses/gpl.html>.
update the year: 2010-2011 (or wait a while and change to 2012 ;-) )

--
To view, visit http://gerrit.ovirt.org/550
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7226817576b713490cdeb098356aee8894af2bfe
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to