Dan Kenigsberg has posted comments on this change. Change subject: storage/misc.py: Add validation to oVirt Node ......................................................................
Patch Set 2: Looks good to me, approved it is a SIN to calculate isOvirt in 4 (four!) different functions. But I do not have an idea how to consolidate them while keeping current vdsm modularity, so ok for now. -- To view, visit http://gerrit.ovirt.org/453 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie35f84712b9165428506798d534fdce8ed2c01af Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
