On Mon, Dec 12, 2011 at 02:41:34PM +0000, Roi Dayan wrote: > Same patch, beside fix to discover command. > I addressed to the last review and that’s why I mailed it here. > About the race. The gui doesn't let you choose between iser or tcp. > So we first try iser and then tcp.
I understand why you do it, but I think the solution is wrong. Is it possible to ask iscsiadm to use iser only during a specific call? Why does there need to be a node state holding the used transport? I think it makes a lot of sense to have one host using both tcp and iser in tandem. If this is currently impossible in iscsiadm, someone has to patch it... Anyway, it is "not fair" to force the default Vdsm user, who never had iser, to first try to discover over iser and fail. Please make the transports that are used a configurational parameter. By default it could be just tcp; people with both tcp and iser could set it to a list tcp,iser. > > I can't use gerrit without and account. > I can't create an account, says on the page someone with an account should > create one for me. I don't understand your error flow. You browse to gerrit.ovirt.org, click Register. What happens next? > On irc #vdsm I was forwarded to #ovirt for help but chanserv always kicks me > out of the channel > with the reason that I'm not authorized to join there. Could it be that you've used the wrong irc server? > > Roi > _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
