Igor Lvovsky has posted comments on this change. Change subject: Remove _addFloppy. floppy is now in _drives. ......................................................................
Patch Set 1: I would prefer that you didn't submit this (2 inline comments) .................................................... File vdsm/libvirtvm.py Line 820: elif device == 'floppy': I know that this patch about the floppy, but cdrom has different device 'cdrom' as well. Do we need special handling for it. .................................................... File vdsm/vm.py Line 362: The lines is too long, please keep it up to 80 -- To view, visit http://gerrit.ovirt.org/629 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifebc05f25bbc4867a5058cc51799d8573a5d8d64 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
