Federico Simoncelli has posted comments on this change. Change subject: Improve the cleanStorageRepository method ......................................................................
Patch Set 1: (1 inline comment) .................................................... File vdsm/storage/hsm.py Line 277: else: This part is in charge of treating *only* symlinks (see line 270). Maybe you meant "simplify and treat as relative symlink". The two way of symlinking /base/foo/bar to /base/egg/bacon are: /base/foo/bar -> ../egg/bacon /base/foo/bar -> /base/egg/bacon To build the full path from the relative symlink we use the source dirname /base/foo and we add the target (relative path) ../egg/bacon obtaining: /base/foo/../egg/bacon. Then abspath normalizes the path to /base/egg/bacon. If we use the same algorithm for a symlink absolute path we obtain: /base/foo/base/egg/bacon, which is wrong. -- To view, visit http://gerrit.ovirt.org/631 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4b1733bfa4145bbec07860be41dccafebd584fc3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
