Dan Kenigsberg has posted comments on this change. Change subject: new verb: migration cancel ......................................................................
Patch Set 7: I would prefer that you didn't submit this (3 inline comments) .................................................... File vdsm/libvirtvm.py Line 436: self._migCancelEvt1.clear() The race here has to be documented with a big FIXME (if it survives the next version of this patch) Line 451: self._vm._dom.abortJob() how about always calling abortJob, but ignoring the exception if we are in migrationPreparation? It is much better to fail migrateCancel, than to wrongly report its success. .................................................... File vdsm/vm.py Line 109: self._migCancelEvt1 = threading.Event() the names are really bad :-( how about _preparingMigrationEvt and and _migrationCanceledEvt? btw, no one waits on these events, so nothing compels us from using plain booleans instead. -- To view, visit http://gerrit.ovirt.org/480 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4f503c444c4ca1469c18480d6ca29fba8f011d4c Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
