Dan Kenigsberg has posted comments on this change. Change subject: fix getMasterDomain masterVersion handling ......................................................................
Patch Set 9: I would prefer that you didn't submit this (2 inline comments) .................................................... Commit Message Line 9: if getMasterDomain() gets -1 as the expected masterVersion it skip English parsing error. Could you rewrite what the code should be doing? .................................................... File vdsm/storage/sp.py Line 681 this stanza is a part of _saveReconnect as the stuff that you moved around. this refactoring seems reasonable, but unrelated to the patch and incomplete. -- To view, visit http://gerrit.ovirt.org/431 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2e5dd06800e770c098460466fa8642c5bc928e54 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
