Dan Kenigsberg has posted comments on this change.
Change subject: Make exporting more pythonic
......................................................................
Patch Set 12: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File vdsm/storage/hsm.py
Line 87: declogger = kwargs.get("logger", logged())
pardon my ignorance, by why "declogger"? what's "dec"
Line 191: em.ResourceManager.getInstance().registerNamespace(STORAGE,
rm.SimpleResourceFactory())
em? probably meant rm
--
To view, visit http://gerrit.ovirt.org/208
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4e26da2a53bae5e897cebdb41af9abe519760aca
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
