Dan Kenigsberg has posted comments on this change.
Change subject: BZ#674010 - Fix name error in vdsClient - 'commands' not found
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm_cli/vdsClient.py
Line 1464: commands = {}
to me it makes more sense to move the original definition of commands to here.
ahm, actually - it should be out of the try:except block.
--
To view, visit http://gerrit.ovirt.org/906
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I091b32ff19d59ec7036ee440ee60913c06be4c13
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Haim Ateya <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Haim Ateya <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches