Dan Kenigsberg has posted comments on this change. Change subject: iscsi.py: fixed discovery issue and added support for iSER transport ......................................................................
Patch Set 1: I would prefer that you didn't submit this (4 inline comments) .................................................... File vdsm/storage/iscsi.py Line 37: SENDTARGETS_DISCOVERY = [constants.EXT_ISCSIADM, "-m", "discoverydb", "-t", "sendtargets", "-o", "new", "-o", "delete"] please keep new code shorter than 80 chars. Line 257: setNodeTransport(portal, iqn, 'iser') attempted transports should be take from config. most users should not try iser and fail, if they care only about tcp. Line 259: rc = misc.execCmd(cmd)[0] if vdsm dies here, host is stuck in iser mode. I do not like that. Please make iscsiadm accept the transport in its command line. Line 261: if rc == ISCSI_ERR_LOGIN_AUTH_FAILED: no tabs, please. -- To view, visit http://gerrit.ovirt.org/905 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1012219f5202882db62743e5f2cf5cbcaaca930a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Roi Dayan <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
