Dan Kenigsberg has posted comments on this change. Change subject: Use a copy of the domainsToUpgrade ......................................................................
Patch Set 1: Looks good to me, approved (1 inline comment) but please mention 771329 .................................................... File vdsm/storage/sp.py Line 391: domains = self._domainsToUpgrade[:] I do not share your opinion about readability, but mine is not very strong. -- To view, visit http://gerrit.ovirt.org/900 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3de0646af2fe9a9fcde708837cfcd83d10385026 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
