Dan Kenigsberg has posted comments on this change.

Change subject: Move limit configuration to it's proper place
......................................................................


Patch Set 1: Looks good to me, approved

(1 inline comment)

....................................................
File vdsm/config.py.in
Line 128: 
this may result in surprise on upgrade path - if someone has 
max_open_files=nondefault on his vdsm.conf.

HOWEVER I'm willing to accept this, since these are very few and very technical 
users who could handle (and would prefer) this sitting in limits.d

Though may require a release note in the relevant bug.

--
To view, visit http://gerrit.ovirt.org/914
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I26345e634e59512c47ce5a52179d65951787c5c6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to