Federico Simoncelli has posted comments on this change.
Change subject: Specify which user/group should be used for core dumps rotation
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File vdsm.spec.in
Line 34: Requires: logrotate >= 3.8.0
If this is different in fedora/rhel, split it in the %if 0%{?rhel}/%else parts.
....................................................
File vdsm/vdsm-logrotate.conf.in
Line 19: su @VDSMUSER@ @VDSMGROUP@
Make this as a complete macro eg: @LOGROTATE_SU_CONFIG@ which is empty on rhel
(you should detect that on configure, probably checking the logrotate version).
--
To view, visit http://gerrit.ovirt.org/971
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I38738f494e9bd241ea27e6e18b4d348fc3dfe643
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: [email protected]
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
