Dan Kenigsberg has posted comments on this change. Change subject: Set exc_info=True when self.message is used in log.error for vds_bootstrap ......................................................................
Patch Set 2: (1 inline comment) .................................................... File vds_bootstrap/vds_bootstrap.py Line 632: logging.error(self.message, exc_info=True) Eduardo, this function is badly written, but it is not within Haim's mandate to rewrite it (it is within yours...) I did not understand what you've said about fReturn -- To view, visit http://gerrit.ovirt.org/945 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id5fa63d9809e5f7130e304eceede6d41a27a12a6 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Haim Ateya <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Haim Ateya <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
