Itamar Heim has posted comments on this change. Change subject: This patch adds some basic debian support ......................................................................
Patch Set 1: i guess a matter of taste. my view it is kind of a magic number. you want to be able to change it via config rather than via code. could call it a property file i guess i agree it is not something user should change (in engine we use config for anything which change should not require a code change, but not all are user changeable). my point is tomorrow you will want to add another list of packages per another distro - you shouldn't need to change your code for that. but i don't feel strongly about it -- To view, visit http://gerrit.ovirt.org/1110 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie021cd9f64f80fde2442b6ad7c75c0b5b1c746ff Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Matthias Heinz <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Itamar Heim <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
