Dan Kenigsberg has posted comments on this change. Change subject: Remove the _preparedDrives dictionary from vm ......................................................................
Patch Set 4: I would prefer that you didn't submit this (2 inline comments) .................................................... File vdsm/vm.py Line 575: # a race with _cleanup but the race still exists: if destroy() is called right after self.destroyed is checked, _cleanup may be quicker than preparePaths, try to teardown drive, swallow the failure, and we are going to prepare drive in line 577. We end up with a leaked volume (which is not the end of the world, just ugly). Line 861: drive, exc_info=True) is exc_info=True intentional? -- To view, visit http://gerrit.ovirt.org/1123 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8d310f216987b7ded89e71752464934f70c051ad Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
