Mark Wu has posted comments on this change.
Change subject: Ignore differences in case when comparing mac addresses
......................................................................
Patch Set 1:
Yes. I created a VM whose mac address has upper case character, and then I got
the following exception:
Thread-42::ERROR::2012-01-14 08:53:59,503::utils::393::vm.Vm::(collect)
vmId=`c9d25ee1-d4a9-424e-970a-c55daf52961e`::Stats function failed:
<AdvancedStatsFunction _sampleNet at 0x2c36420>
Traceback (most recent call last):
File "/usr/share/vdsm/utils.py", line 389, in collect
statsFunction()
File "/usr/share/vdsm/utils.py", line 266, in __call__
retValue = self._function(*args, **kwargs)
File "/usr/share/vdsm/libvirtvm.py", line 171, in _sampleNet
netSamples[nic.name] = self._vm._dom.interfaceStats(nic.name)
AttributeError: 'NetworkInterfaceDevice' object has no attribute 'name'
This should be caused by that the function _getUnderlyingNetworkInterfaceInfo
didn't update the 'name' successfully because of the mismatched mac address. It
seems libvirt always store the mac address in lower case in XML file. But I am
not sure about it, so I just compare the lower case of the two addresses.
--
To view, visit http://gerrit.ovirt.org/1059
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id59b2228f83aa2506da1f4a1011469e63dfc1e9c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
