Saggi Mizrahi has posted comments on this change. Change subject: added mtu support for network interface ......................................................................
Patch Set 3: I would prefer that you didn't submit this (2 inline comments) .................................................... File vdsm/configNetwork.py Line 223: s = s + 'MTU=%s\n' % pipes.quote(mtu) Use %d, we do want it to fail if it's not a number Line 312: ''' method Search entry in conffile and return Rouge space -- To view, visit http://gerrit.ovirt.org/754 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d8f38627dd1a59830e426484228c1796081ad1b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Peter V. Saveliev <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
