Dan Kenigsberg has posted comments on this change.
Change subject: fixed iscsi discovery and added iSER transport support
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
Thanks for your patch, however, please review my former comments.
I'd be happy if the default would be to completely avoid changing the transport.
And I really need an iscsiadm bug for the transport issue.
....................................................
File vdsm/config.py.in
Line 216: ('iscsi_transports', 'tcp', None ),
documentation instead of "None" is recommended
....................................................
File vdsm/storage/iscsi.py
Line 39: SENDTARGETS_DISCOVERY = [constants.EXT_ISCSIADM, "-m", "discoverydb",
"-t", "sendtargets", "-o", "new", "-o", "delete"]
it does not seem that you've addressed my comments in
http://gerrit.ovirt.org/#patch,sidebyside,905,1,vdsm/storage/iscsi.py
Please do.
Also, consider rebasing over http://gerrit.ovirt.org/#change,1249
--
To view, visit http://gerrit.ovirt.org/1350
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie932ecd4b382aa99ef1bb20882ea44291ba39f47
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roi Dayan <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
