Igor Lvovsky has posted comments on this change.
Change subject: Added an option to create a memory balloon device.
......................................................................
Patch Set 5: I would prefer that you didn't submit this
(4 inline comments)
....................................................
File vdsm/libvirtvm.py
Line 1885: xml = xml.dom.minidom.parseString(self._lastXMLDesc) \
c'mon man. 'xml' is a valid python module, you can't use it as local
variable. Please consider something like 'balloonxml'
Line 1887: .getElementsByTagName('memballon')
memballon -> memballoon
....................................................
File vdsm/vm.py
Line 423: 'device': 'memballon', 'model': 'none'})
memballon -> memballoon
Line 424:
I think that right think it's to move this code to separate function like
getConfBallon(). In such case you will call it only for old API (instead of [])
and you shouldn't to check len()
--
To view, visit http://gerrit.ovirt.org/1573
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie25eec67f852a4e0eedf96cf6da4094dab3386c5
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Gal Hammer <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Gal Hammer <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
